On Wed, 5 Nov 2008, Laurent Vivier wrote:
> > >+ break;
> > >+ default:
> > >+ swim_base = NULL;
> > >+ break;
> > >+ }
> > >+
> > >+ if (dev->id == 0 && base)
> > >+ swim_base = (struct swim *)base;
> > >+
> > >+ if (swim_base == NULL)
> > >+ return -ENODEV;
> >
> >I think dev->id is always 0?
>
> Yes, but as platform driver allows to have several instance of platform device
> I though if we suppose we have several SWIM we should use the module parameter
> only with the first one.
> I can remove this if you think it is useless.
Dead code adds complexity and therefore requires more work (if only to
figure out whether it is a bug or not). Compare with,
default:
swim_base = (struct swim *)base;
break;
}
if (swim_base == NULL)
return -ENODEV;
Finn
>
> Thank you for your comments.
>
> Regards,
> Laurent
> ----------------------- Laurent Vivier ----------------------
> "The best way to predict the future is to invent it."
> - Alan Kay
>
>
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
