On Wed, 19 Nov 2008, Michael Schmitz wrote:
> > Make sure fix->line_length is always set, as some applications need it
> > because
> > they don't have fallback code if line_length is zero.
> >
> > Works on ARAnyM (Falcon emulation), but par->next_line is not set on any
> > other
> > Atari variant?
>
> You're right - while testing on the Falcon framebuffer I noticed
> fix->line_length needs to be set, and kludged around to get it set to
> something
> more or less sane, but I could not test the other code paths.
>
> It looks like par->next_line should be set to linelen in all other decode_var
> variants. The quilt tree here does have fix->line_length = par->next_line
> already, what is your patch based on?
It was based on mainline. Yes, a part of my patch had been in my quilt series
for a while, but I wanted to post the full thing for review.
> I had
>
> fix->line_length = (par->hw.falcon.line_width + par->hw.falcon.line_offset) *
> par->hw.falcon.bpp / 8;
>
> originally - I suppose this had to change with your cfb fixes?
That should be OK. Strange, it's not what I got from you, cfr. atafb in
mainline.
Cfb16 needed
1. fix->line_length to be valid (it was zero)
2. info->pseudo_palette
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
