Hi,
> > It looks like par->next_line should be set to linelen in all other
> > decode_var
> > variants. The quilt tree here does have fix->line_length = par->next_line
> > already, what is your patch based on?
>
> It was based on mainline. Yes, a part of my patch had been in my quilt series
> for a while, but I wanted to post the full thing for review.
OK, I see.
> > I had
> >
> > fix->line_length = (par->hw.falcon.line_width + par->hw.falcon.line_offset)
> > *
> > par->hw.falcon.bpp / 8;
> >
> > originally - I suppose this had to change with your cfb fixes?
>
> That should be OK. Strange, it's not what I got from you, cfr. atafb in
> mainline.
I concede this may be something I changed later on. atafb had been worked on my
Roman Zippel as well after my initial patches so I'll double check this isn't
obsolete (I was looking at my current working tree though).
> Cfb16 needed
> 1. fix->line_length to be valid (it was zero)
> 2. info->pseudo_palette
OK, so the above fix->line_length may be independent from your fixes.
I'll test that (just not right away, home improvement work has taken a heavy
toll on my time lately).
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
