Hi,

following up on Geert's report that atarimouse does fail to load as a module 
(with ENODEV), here's the fix. 

Brown paper bag, well and truely. Got the semantics of the atari_keyb_init 
return reversed (not that atari_keyb_init ever returns anything but success, 
but 
that's for another day).

I still get no mouse events in either /dev/input/mice or .../mouse0, though. I 
suspect the mouse open hook never gets called. Same bug might affect amimouse 
(though the open function does do the full hardware setup there).

        Michael

 drivers/input/mouse/atarimouse.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/mouse/atarimouse.c b/drivers/input/mouse/atarimouse.c
index a57143c..1b5f4dd 100644
--- a/drivers/input/mouse/atarimouse.c
+++ b/drivers/input/mouse/atarimouse.c
@@ -118,7 +118,7 @@ static int __init atamouse_init(void)
        if (!MACH_IS_ATARI || !ATARIHW_PRESENT(ST_MFP))
                return -ENODEV;
 
-       if (!atari_keyb_init())
+       if (atari_keyb_init())
                return -ENODEV;
 
        atamouse_dev = input_allocate_device();

Signed-off-by: Michael Schmitz <[email protected]>


--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to