Re: [PATCH] mac8390: fix pr_info() calls and change return code

[Finn Thain]

Signed-off-by: Finn Thain <fth...@telegraphics.com.au>

--- a/drivers/net/mac8390.c     2010-04-16 13:31:04.000000000 +1000
+++ b/drivers/net/mac8390.c     2010-04-16 14:02:29.000000000 +1000
@@ -554,7 +554,7 @@
        case MAC8390_APPLE:
                switch (mac8390_testio(dev->mem_start)) {
                case ACCESS_UNKNOWN:
-                       pr_info("Don't know how to access card memory!\n");
+                       pr_err("Don't know how to access card memory!\n");
                        return -ENODEV;
                        break;
 
@@ -643,8 +643,8 @@
 {
        __ei_open(dev);
        if (request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev)) {
-               pr_info("%s: unable to get IRQ %d.\n", dev->name, dev->irq);
-               return -EAGAIN;
+               pr_err("%s: unable to get IRQ %d.\n", dev->name, dev->irq);
+               return -EBUSY;
        }
        return 0;
 }
@@ -660,7 +660,7 @@
 {
        ei_status.txing = 0;
        if (ei_debug > 1)
-               pr_info("reset not supported\n");
+               printk(KERN_DEBUG "reset not supported\n");
        return;
 }
 
@@ -668,11 +668,11 @@
 {
        unsigned char *target = nubus_slot_addr(IRQ2SLOT(dev->irq));
        if (ei_debug > 1)
-               pr_info("Need to reset the NS8390 t=%lu...", jiffies);
+               printk(KERN_DEBUG "Need to reset the NS8390 t=%lu...", jiffies);
        ei_status.txing = 0;
        target[0xC0000] = 0;
        if (ei_debug > 1)
-               pr_cont("reset complete\n");
+               printk(KERN_CONT "reset complete\n");
        return;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html