From: Finn Thain <fth...@telegraphics.com.au> Date: Fri, 16 Apr 2010 23:57:34 +1000 (EST)
> > On Thu, 15 Apr 2010, Joe Perches wrote: > >> ...Why is it better to use -EBUSY? > > Nubus slots are geographically addressed and their irqs are equally > inflexible. -EAGAIN is misleading because retrying will not help fix > whatever bug caused the irq to unavailable. This is exactly the kind of background information and verbose explanation that belongs in the commit message. Yet in your recent version of the patch, you're still being extremely terse as per the reasoning for using -EBUSY Just saying it's "misleading" doesn't tell anyone anything if they have to go back in the commit history and try to figure out why this change was made if it's causing problems later. Please make the verbose and complete explanation in your commit message, and resubmit your patch. I just want to point out that with all the trouble you gave about Joe's work, you're having one heck of a time even submitting your changes properly. :-) Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html