Geert,

>> +config ATARI_USB
>> +       bool "Atari USB host controller support"
>> +       depends on ATARI
>> +       select USB_SUPPORT
>> +       select USB_ARCH_HAS_HCD
>
> Nothing actually uses CONFIG_ATARI_USB, it's just used to select USB_SUPPORT
> and USB_ARCH_HAS_HCD?
> Perhaps you can make the platform device creation depend on this?

I could select USB_ARCH_HAS_HCD conditional on USB_SUPPORT on Atari
without the need for an additional option, is that what you mean? I'm
not certain which way the selection works - do I get to select
USB_SUPPORT unconditionally?

Otherwise, both can be enabled unconditionally on Atari now -
inclusion of the HCD is controlled via the driver option.

>> +/*
>> + * EtherNEC: ISA NE2000 compatible card (i.e. Realtek 8019) via ROM-port 
>> adapter
>> + */
>> +
>>  #define ATARI_ETHERNEC_PHYS_ADDR       0xfffa0000
>>  #define ATARI_ETHERNEC_BASE            0x300
>>  #define ATARI_ETHERNEC_IRQ             IRQ_MFP_TIMD
>
> This doesn't belong in this patch.

Oops - need to be more disciplined.

Cheers,

  Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to