On Wed, 2012-07-04 at 14:56 +1000, [email protected] wrote:
> From: Greg Ungerer <[email protected]>
>
> A number of older ColdFire CPU based boards use NS8390 based network
> controllers. Most use the Davicom 9008F or the UMC 9008F. This driver
> provides the support code to get these devices working on these platforms.
Hi Greg, just some trivia:
[]
> diff --git a/drivers/net/ethernet/8390/mcf8390.c
> b/drivers/net/ethernet/8390/mcf8390.c
[]
> +#ifdef NE2000_ODDOFFSET
> +/*
> + * A lot of the ColdFire boards use a separate address region for odd offset
> + * register addresses. The following macros and functions convert and map
> + * as required. Note that the data port accesses are treated a little
> + * differently, and always accessed via the insX/outsX functions.
> + */
> +#define NE_PTR(a) (((a) & 0x1) ? (NE2000_ODDOFFSET + (a) - 1) :
> (a))
Maybe use static inlines instead of macros?
static inline void *NE_PTR(void *ptr)
{
if ((unsigned long)ptr & 1)
return ptr - 1 + NE2000_ODDOFFSET;
return ptr;
}
[]
> +static void mcf8390_get_8390_hdr(struct net_device *dev,
> + struct e8390_pkt_hdr *hdr, int ring_page)
> +{
[]
> + /*
> + * This *shouldn't* happen.
> + * If it does, it's the last thing you'll see
> + */
> + if (ei_status.dmaing) {
> + netdev_err(dev,
> + "%s: DMAing conflict [DMAstat:%d][irqlock:%d]\n",
> + __func__, ei_local->dmaing, ei_local->irqlock);
This message seems to get repeated a few times.
Maybe another function/macro or maybe a BUG?
some_dma_err(dev, __func__, ei_local);
> +static void mcf8390_block_input(struct net_device *dev, int count,
> + struct sk_buff *skb, int ring_offset)
> +{
[]
> + /*
> + * This *shouldn't* happen.
> + * If it does, it's the last thing you'll see
> + */
> + if (ei_local->dmaing) {
> + netdev_err(dev,
> + "%s: DMAing conflict [DMAstat:%d][irqlock:%d]\n",
> + __func__, ei_local->dmaing, ei_local->irqlock);
> + return;
> + }
> +static void mcf8390_block_output(struct net_device *dev, int count,
> + const unsigned char *buf,
> + const int start_page)
> +{
[]
> + /*
> + *This *shouldn't* happen.
> + * If it does, it's the last thing you'll see
> + */
> + if (ei_local->dmaing) {
> + netdev_err(dev,
> + "%s: DMAing conflict [DMAstat:%d][irqlock:%d]\n",
> + __func__, ei_local->dmaing, ei_local->irqlock);
> + return;
> + }
> +static int mcf8390_init(struct net_device *dev)
> +{
> + static u32 offsets[] = {
> + 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
> + 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
> + };
const? u8?
> + pr_debug("Found ethernet address: %pM\n", dev->dev_addr);
netdev_dbg ?
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
