On Wed, 2012-07-04 at 16:18 +1000, Greg Ungerer wrote: > Hi Joe, Hi Greg.
> On 04/07/12 15:18, Joe Perches wrote: > > On Wed, 2012-07-04 at 14:56 +1000, [email protected] wrote: > >> From: Greg Ungerer <[email protected]> > >> > >> A number of older ColdFire CPU based boards use NS8390 based network > >> controllers. Most use the Davicom 9008F or the UMC 9008F. This driver > >> provides the support code to get these devices working on these platforms. [] > >> diff --git a/drivers/net/ethernet/8390/mcf8390.c > >> b/drivers/net/ethernet/8390/mcf8390.c [] > >> +static int mcf8390_init(struct net_device *dev) > >> +{ > >> + static u32 offsets[] = { > >> + 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, > >> + 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f, > >> + }; > > > > const? u8? > > That is assigned to the "reg_offset" field of "struct ei_device" > (defined in the existing 8390.h) and that is: > > u32 *reg_offset; /* Register mapping table */ > > So I can't change this. Sure you can, you can assign a u8 to a u32 just fine. The value fits in a u8. Might as well make it take less data space. static const makes it read-only and makes the compiler assign it just once instead of at function invocation. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
