From: Geert Uytterhoeven <[email protected]>
Date: Tue, 12 Nov 2013 23:44:06 +0100

> On Wed, Nov 13, 2013 at 12:40 AM, Sergei Shtylyov
> <[email protected]> wrote:
>> On 11/13/2013 12:12 AM, David Miller wrote:
>>
>>>>> @@ -100,7 +100,7 @@ struct lance_init_block {
>>>>>     */
>>>>>    struct lance_private
>>>>>    {
>>>>> -        char *name;
>>>>> +        const char *name;
>>
>>
>>>>     Indent with tab, not spaces, please.
>>
>>
>>> This whole file is %99 space indentation, you really can't blame
>>> Geert for this.
>>
>>
>>    It's never late to fix some.
> 
> That would be a separate patch. Care to create and send it?
> 
>> And remember about checkpatch.pl which was hardly content with the patch.
> 
> Only because checkpatch looks at the _new_ lines, and doesn't compare the
> styles of the old and new lines.

You really should fix the line you are changing to use tabs, please respin
with this in mind, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to