Sascha Hauer wrote:
On Fri, Apr 03, 2009 at 02:15:34PM +0200, Guennadi Liakhovetski wrote:
On Fri, 3 Apr 2009, Darius Augulis wrote:

From: Paulius Zaleckas <[email protected]>

Signed-off-by: Darius Augulis <[email protected]>
Signed-off-by: Paulius Zaleckas <[email protected]>
Ok, I'll just swap these two Sob's to reflect the processing chain, add a description like

Add support for CMOS Sensor Interface on i.MX1 and i.MXL SoCs.

and fix a couple of trivial conflicts, which probably appear, because you based your patches on an MXC tree, and not on current linux-next. Wondering, if it still will work then... At least it compiles. BTW, should it really also work with IMX? Then you might want to change this

        depends on VIDEO_DEV && ARCH_MX1 && SOC_CAMERA

to

        depends on VIDEO_DEV && (ARCH_MX1 || ARCH_IMX) && SOC_CAMERA

This shouldn't be necessary. ARCH_IMX does not have the platform part to
make use of this driver and will never get it.

but you can do this later, maybe, when you actually get a chance to test it on IMX (if you haven't done so yet).

Sascha, we need your ack for the ARM part.

I'm OK with this driver: I have never worked with FIQs though so I can't
say much to it.

At least I can confirm it worked well with 2.6.28.5 kernel version.


Sascha


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to