Hi! > Please find my comments below.
Thanks for quick review, will fix.
> > switch (vfwn.base.port) {
> > case ISP_OF_PHY_CSIPHY1:
> > - buscfg->interface = ISP_INTERFACE_CSI2C_PHY1;
> > + if (csi1)
>
> You could compare vfwn.bus_type == V4L2_MBUS_CSI2 for this. But if you
> choose the local variable, please make it bool instead.
I prefer variable, will switch to bool.
> > +
> > + buscfg->bus.ccp2.lanecfg.data[0].pos = 1;
>
> Shouldn't this be vfwn.bus.mipi_csi1.data_lane ?
>
> > + buscfg->bus.ccp2.lanecfg.data[0].pol = 0;
>
> And this one is vfwn.bus.mipi_csi1.lane_polarity[1] .
Thanks for catching this.
Checkpatch issues will be fixed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
