On 28/08/18 12:40, Philippe De Muyter wrote:
> Hi Hans,
>
> On Tue, Aug 28, 2018 at 12:29:21PM +0200, Hans Verkuil wrote:
>> On 28/08/18 12:26, Philippe De Muyter wrote:
>>> Hi Hans,
>>>
>>> On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote:
>>>> This is a bit too magical for my tastes. I'd add a type field:
>>>>
>>>> #define V4L2_SUBDEV_FRMIVAL_TYPE_DISCRETE 0
>>>> #define V4L2_SUBDEV_FRMIVAL_TYPE_CONTINUOUS 1
>>>> #define V4L2_SUBDEV_FRMIVAL_TYPE_STEPWISE 2
>
> Should I put that in an enum like 'enum v4l2_subdev_format_whence'
> or use simple define's ?
Use an enum for consistency with the existing framesize/ival APIs.
Regards,
Hans
