Hello Mauro, > > no, the default value of retval makes no difference to the function. > > > > Retval is set by si470x_disconnect_check and si470x_set_register. > > After each call, retval is checked. > > There is no need to reset it passed.
> You may just do then: > > int retval = si470x_disconnect_check(radio); In all other set/get functions of v4l2_ioctl_ops in the driver, I just set the default value of retval to 0. To be identical in si470x_vidioc_s_tuner, I modified the patch to the one below. I already pushed this and another cosmetic patch into mercurial: http://linuxtv.org/hg/~tlorenz/v4l-dvb/rev/72a2f38d5956 http://linuxtv.org/hg/~tlorenz/v4l-dvb/rev/3efd5d32a618 Mauro, can you pull them? Bye, Tobias --- a/linux/drivers/media/radio/si470x/radio-si470x-common.c Thu Feb 11 23:11:30 2010 -0200 +++ b/linux/drivers/media/radio/si470x/radio-si470x-common.c Thu Feb 18 20:31:33 2010 +0100 @@ -748,7 +748,7 @@ struct v4l2_tuner *tuner) { struct si470x_device *radio = video_drvdata(file); - int retval = -EINVAL; + int retval = 0; /* safety checks */ retval = si470x_disconnect_check(radio); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
