Em 09-09-2010 06:19, Pawel Osciak escreveu: > Hello, > > These patches add a new driver framework for Video for Linux 2 driver > - Videobuf2.
I didn't test the patches, but, from a source code review, they seem on a good shape. I did a few comments on some patches. There are a few missing features for them to be used with real drivers: 1) it lacks implementation of read() method. This means that vivi driver has a regression, as it currently supports it. 2) it lacks OVERLAY mode. We can probably mark this feature as deprecated, avoiding the need of implementing it on videobuf2, but we need a patch for Documentation/feature-removal-schedule.txt, in order to allow the migration of the existing drivers like bttv and saa7134, where this feature is implemented, of course if people agree that this is the better way; 3) it lacks the implementation of videobuf-dvb; 4) it lacks an implementation for DMA S/G. We need to address all the above issues, in order to use it, otherwise the migration of existing drivers would cause regressions, as features will be missing. Cheers, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
