On Friday 20 January 2012 17:20:22 Tomasz Stanislawski wrote: > >> IMO, One way to do this is adding field 'struct device *dev' to struct > >> vb2_queue. This field should be filled by a driver prior to calling > >> vb2_queue_init. > > > > I haven't looked into the details, but that sounds good to me. Do we have > > use cases where a queue is allocated before knowing which physical > > device it will be used for ? > > I don't think so. In case of S5P drivers, vb2_queue_init is called while > opening /dev/videoX. > > BTW. This struct device may help vb2 to produce logs with more > descriptive client annotation. > > What happens if such a device is NULL. It would happen for vmalloc > allocator used by VIVI?
Good question. Should dma-buf accept NULL devices ? Or should vivi pass its V4L2 device to vb2 ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
