Em Mon, 14 Mar 2016 09:25:51 +0100
Hans Verkuil <hverk...@xs4all.nl> escreveu:

> I was fixing a sparse warning in media_entity_pads_init() and I noticed that 
> that
> function always returns 0. Any reason why this can't be changed to a void 
> function?
> 
> That return value is checked a zillion times in the media code. By making it 
> void
> it should simplify code all over.
> 
> See e.g. uvc_mc_init_entity in drivers/media/usb/uvc/uvc_entity.c: that whole
> function can become a void function itself.


This function were called media_entity_init(), and it used to have a
code that would allocate the links array. The way it is right now, I
don't see any reason to keep returning an error code.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to