On Wed, Feb 23, 2011 at 05:29:12PM -0500, Chris Ball wrote: > drivers/mmc/host/sdhci-pci.c: In function ‘sdhci_pci_probe_slot’: > drivers/mmc/host/sdhci-pci.c:913:18: warning: variable ‘addr’ set but > not used [-Wunused-but-set-variable] > > Signed-off-by: Chris Ball <[email protected]> > Cc: Michał Mirosław <[email protected]> > --- > drivers/mmc/host/cb710-mmc.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c > index 66b4ce5..280c03a 100644 > --- a/drivers/mmc/host/cb710-mmc.c > +++ b/drivers/mmc/host/cb710-mmc.c > @@ -179,7 +179,6 @@ static int cb710_wait_for_event(struct cb710_slot *slot, > u8 what) > static int cb710_wait_while_busy(struct cb710_slot *slot, uint8_t mask) > { > unsigned limit = 500000; /* FIXME: real timeout */ > - int err = 0; > > #ifdef CONFIG_CB710_DEBUG > u32 e, x; > @@ -190,7 +189,6 @@ static int cb710_wait_while_busy(struct cb710_slot *slot, > uint8_t mask) > if (!--limit) { > cb710_dump_regs(cb710_slot_to_chip(slot), > CB710_DUMP_REGS_MMC); > - err = -ETIMEDOUT; > break; > } > udelay(1);
What about changing return 0 into return err? It gets checked in cb710_mmc_powerup(). The _other two_ patches: Acked-by: Wolfram Sang <[email protected]> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
