On Wed, Feb 23, 2011 at 11:17:43PM +0000, Chris Ball wrote: > Fixes: > > drivers/mmc/host/cb710-mmc.c: In function ‘cb710_wait_while_busy’: > drivers/mmc/host/cb710-mmc.c:182:6: warning: variable ‘err’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Chris Ball <[email protected]> > Cc: Michał Mirosław <[email protected]> > Cc: Wolfram Sang <[email protected]> > --- > Hi Wolfram, > > > What about changing return 0 into return err? It gets checked in > > cb710_mmc_powerup(). > > Thanks, good idea. > > - Chris. > > drivers/mmc/host/cb710-mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c > index 66b4ce5..ce2a47b 100644 > --- a/drivers/mmc/host/cb710-mmc.c > +++ b/drivers/mmc/host/cb710-mmc.c > @@ -205,7 +205,7 @@ static int cb710_wait_while_busy(struct cb710_slot *slot, > uint8_t mask) > "WAIT12: waited %d loops, mask %02X, entry val %08X, > exit val %08X\n", > limit, mask, e, x); > #endif > - return 0; > + return err; > } > > static void cb710_mmc_set_transfer_size(struct cb710_slot *slot,
This patch is good. This part is not completely demystified though, and some parts of the code don't care about this function's return value. Acked-by: Michał Mirosław <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
