Hi Arindam, On Fri, May 20, 2011 at 5:46 AM, Nath, Arindam <[email protected]> wrote: > Hi Andrei, > > [...] >> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h >> index 7e28eec..713caf0 100644 >> --- a/drivers/mmc/host/sdhci.h >> +++ b/drivers/mmc/host/sdhci.h >> @@ -25,6 +25,7 @@ >> */ >> >> #define SDHCI_DMA_ADDRESS 0x00 >> +#define SDHCI_ARGUMENT2 0x00 > > Since SDHCI_DMA_ADDRESS and SDHCI_ARGUMENT2 in actually the same register, > probably ... > > #define SDHCI_ARGUMENT2 SDHCI_DMA_ADDRESS
Sure. >> #define SDHCI_TRNS_ACMD12 0x04 >> +#define SDHCI_TRNS_ACMD23 0x08 > > How about changing these names explicitly to _AUTO_CMD12 and _AUTO_CMD23? > That way we are less likely to get confused with App commands with same names. Sounds good. >> #define SDHCI_ACMD12 (1<<6) /* Auto CMD12 support */ >> +#define SDHCI_ACMD23 (1<<7) /* Auto CMD23 support */ > Ok, will clean it up. A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
