On Tuesday, March 06, 2012, Guennadi Liakhovetski wrote: > On Tue, 6 Mar 2012, Rafael J. Wysocki wrote: > > > On Tuesday, March 06, 2012, Guennadi Liakhovetski wrote: > > > On Sun, 4 Mar 2012, Rafael J. Wysocki wrote: > > > > > > > From: Rafael J. Wysocki <[email protected]> > > > > > > > > Make tmio_mmc populate the pm_qos member of struct mmc_host, to > > > > let the core know that it should create the pm_latency_limit_ms > > > > host attribute for it, and set the default value of that attribute > > > > to 100 ms. > > > > > > > > Signed-off-by: Rafael J. Wysocki <[email protected]> > > > > --- > > > > drivers/mmc/host/tmio_mmc_pio.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > Index: linux/drivers/mmc/host/tmio_mmc_pio.c > > > > =================================================================== > > > > --- linux.orig/drivers/mmc/host/tmio_mmc_pio.c > > > > +++ linux/drivers/mmc/host/tmio_mmc_pio.c > > > > @@ -918,6 +918,12 @@ int __devinit tmio_mmc_host_probe(struct > > > > if (ret < 0) > > > > goto pm_disable; > > > > > > > > + mmc->pm_qos = kzalloc(sizeof(*mmc->pm_qos), GFP_KERNEL); > > > > > > Why don't you just add pm_qos to struct tmio_mmc_host? > > > > Because the core has to see it. > > Yes, I understand that. So, you just assign a pointer to it to > mmc->pm_qos, just avoiding an extra allocation / freeing / error handling.
Well, I think this is a very minor point. I'm going to move the sysfs attribute creation to the PM core anyway. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
