Hi Yongd, From my perspective I don't think this patch is wanted.
A retry mechanism is likely very much hw-SDIO device dependent. Upper layers (SDIO func driver) is thus the only software that is able to handle retries correctly.
Kind regards Ulf Hansson On 05/14/2012 10:39 AM, yongd wrote:
Set sdio CMD52/53's retry time as MMC_CMD_RETRIES. As a result, sdio might benefit from core-internal CMD retry mechanism when some errors happen(CRC, etc). Signed-off-by: yongd<[email protected]> --- drivers/mmc/core/sdio_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/sdio_ops.c b/drivers/mmc/core/sdio_ops.c index d29e206..884c27e 100644 --- a/drivers/mmc/core/sdio_ops.c +++ b/drivers/mmc/core/sdio_ops.c @@ -86,7 +86,7 @@ static int mmc_io_rw_direct_host(struct mmc_host *host, int write, unsigned fn, cmd.arg |= in; cmd.flags = MMC_RSP_SPI_R5 | MMC_RSP_R5 | MMC_CMD_AC; - err = mmc_wait_for_cmd(host,&cmd, 0); + err = mmc_wait_for_cmd(host,&cmd, MMC_CMD_RETRIES); if (err) return err; @@ -147,6 +147,7 @@ int mmc_io_rw_extended(struct mmc_card *card, int write, unsigned fn, else cmd.arg |= 0x08000000 | blocks; /* block mode */ cmd.flags = MMC_RSP_SPI_R5 | MMC_RSP_R5 | MMC_CMD_ADTC; + cmd.retries = MMC_CMD_RETRIES; data.blksz = blksz; /* Code in host drivers/fwk assumes that "blocks" always is>=1 */
-- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
