Hi, On Mon, Sep 17 2012, Guennadi Liakhovetski wrote: > On Mon, 17 Sep 2012, Chris Ball wrote: > >> From: Guennadi Liakhovetski <[email protected]> >> >> Previously to this patch, an SDHCI platform that uses a GPIO for >> card detection instead of the internal SDHCI_CARD_PRESENT bit on >> the presence register would fail to bring up a new card because >> logic in sdhci_request() fails the request if that bit is 0. >> >> Some drivers worked around this in various ways: esdhc-imx defines >> an IO accessor to fake the presence bit being true, s3c turns on >> polling (which stops the SDHCI driver from checking the bit) after >> a card's inserted. But none of this should be necessary; the real >> fix is to check whether we're using a GPIO and avoid relying on >> the presence bit if so, as this patch implements. >> > > Well, ok, thanks for attributing this patch to me:-) I guess then my Sob > should go in the first, as you'll be forwarding the patch upstream? But > feel free to swap them if you disagree > > Signed-off-by: Guennadi Liakhovetski <[email protected]>
Yes, I'll put yours in first. Pushed to mmc-next for 3.7; thanks! - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
