On Mon, Nov 19, 2012 at 03:15:53AM +0000, Huang Changming-R66093 wrote:
[...]
> > > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host *mmc)
> > > > return ret;
> > > > }
> > > >
> > > > +/* Return values for the sdjco_get_cd callback:
> > > > + * 0 for a absent card
> > > > + * 1 for a present card
> > > > + * -ENOSYS when not supported (equal to NULL callback)
> > > > + */
> >
> > Incorrect style.
> Hi, Anton, you mean the comment style is incrorrect?
> It should be:
> /*
> * xxxxx
> * xxxxxx
> */
Yup.
>
> > > > +static int sdhci_get_cd(struct mmc_host *mmc) {
> >
> > ditto
> I don't see the issue, could you explain it?
The issue is in the brace placement. It should be
static int sdhci_get_cd(struct mmc_host *mmc)
{
...
}
Please refer to Documentation/CodingStyle -- it's a great document.
Thanks,
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
