On Mon, 2009-05-18 at 17:03 +0100, Alan Jenkins wrote: > On 5/18/09, Andreas Robinson <[email protected]> wrote: > > So, when asked to load a file that is not an elf-file, what should modprobe > > do? > > > > 1. fail silently if (error == warn && !verbose) or > > 2. always fail noisily, same as if e.g the file didn't exist. > > > > Up to this point, case 1 is true. > > After applying the patch, case 2 would be true, if the hack didn't revert to > > the old behvior. > > > > I'm not sure what the right thing to do is here. > > For what it's worth, 2) sounds fine to me. > > I guess it also means corrupted module files won't show up in the > kernel log. (Which was theoretically convenient for early boot or > headless systems). But I don't think it's worth worrying about. > > Apart from corrupted files, it sounds like this would also apply when > trying to load a compressed module without enabling zlib?
Yes, that's right. > I think > it's right to be noisy in these cases, and it will make more sense if > the error comes from userspace instead of from the kernel. Ok, got it. I'll remove the hack and adjust the tests in another patch. -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
