Hi Artem,
I hope this message finds you well.
I've encountered a compilation issue when KERNEL_REPLICATION is disabled in the
config.
ld: vmlinux.o: in function `alloc_insn_page':
/home/amd/linux_mainline/arch/x86/kernel/kprobes/core.c:425: undefined
reference to `numa_set_memory_rox'
ld: vmlinux.o: in function `alloc_new_pack':
/home/amd/linux_mainline/kernel/bpf/core.c:873: undefined reference to
`numa_set_memory_rox'
ld: vmlinux.o: in function `bpf_prog_pack_alloc':
/home/amd/linux_mainline/kernel/bpf/core.c:891: undefined reference to
`numa_set_memory_rox'
ld: vmlinux.o: in function `bpf_trampoline_update':
/home/amd/linux_mainline/kernel/bpf/trampoline.c:447: undefined reference to
`numa_set_memory_rox'
ld: vmlinux.o: in function `bpf_struct_ops_map_update_elem':
/home/amd/linux_mainline/kernel/bpf/bpf_struct_ops.c:515: undefined reference
to `numa_set_memory_rox'
ld: vmlinux.o:/home/amd/linux_mainline/kernel/bpf/bpf_struct_ops.c:524: more
undefined references to `numa_set_memory_rox' follow
After some investigation, I've put together a patch that resolves this
compilation issues for me.
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -2268,6 +2268,15 @@ int numa_set_memory_nonglobal(unsigned long addr, int
numpages)
return ret;
}
+
+#else
+
+int numa_set_memory_rox(unsigned long addr, int numpages)
+{
+ return set_memory_rox(addr, numpages);
+
+}
+
#endif
Additionally, I'm interested in evaluating the performance impact of this
patchset on AMD processors.
Could you please point me the benchmarks that you have used in cover letter?
Best Regards,
Shivank
