On Sat, Nov 8, 2025 at 5:42 AM Sami Tolvanen <[email protected]> wrote: > > Ah, nevermind. I was looking at a stale object file. If there are no > exports, we should obviously skip gendwarfksyms.
Ah, good, thanks, I was wondering if I was missing something. > For C objects, we use nm to check for __export_symbol_* symbols > before we attempt to generate symbol versions (see gen_symversions > in scripts/Makefile.build). We could do something similar for Rust > objects too, or just bail out early in gendwarfksyms if it's passed an > empty symbol list. Exactly, that is what I was suggesting in the other thread about editing the `cmd` command or directly teaching `genkallksyms` to auto-skip, but I didn't know if there was a reason you didn't do that originally instead of having (some of) the `skip_*` lines in the `Makefile`. If not, then I assume we could already remove some of those lines, e.g. the one for `ffi.o` (no need to do it on the fix, of course, better to keep it minimal, but just to confirm there is no hidden reason there). Cheers, Miguel
