Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] kconfig: turning DEBUG_INFO_BTF into tristate silently disables dependent bool features --
commit f23aaa487601db0500af9e21873fa5fc4f1af7b5 Author: Jay Wang <[email protected]> kbuild, bpf: allow building the vmlinux BTF as a module This commit makes CONFIG_DEBUG_INFO_BTF a tristate. It allows the vmlinux BTF to be built as a module (btf_vmlinux) that is loaded on demand, saving memory when it is not needed. > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 134b15a44625e..418025c5e6577 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -396,7 +396,7 @@ config DEBUG_INFO_SPLIT > Incompatible with older versions of ccache. > > config DEBUG_INFO_BTF > - bool "Generate BTF type information" > + tristate "Generate BTF type information" [Severity: High] Does this change cause a regression where dependent boolean features are disabled when CONFIG_DEBUG_INFO_BTF is configured as a module? In Kconfig, when a bool option depends on an expression that evaluates to m, its upper bound is restricted. Since a bool cannot hold an m value, Kconfig evaluates the option to disabled. Several major kernel features are boolean options that depend directly on CONFIG_DEBUG_INFO_BTF, including CONFIG_SCHED_CLASS_EXT, CONFIG_NET_SCH_BPF, CONFIG_DEBUG_INFO_BTF_MODULES, and CONFIG_PROBE_EVENTS_BTF_ARGS. Setting CONFIG_DEBUG_INFO_BTF to m evaluates these dependencies to m, which causes these features to be omitted from the build. Could the dependencies be updated to evaluate to y when BTF is built as a module, such as using depends on DEBUG_INFO_BTF != n? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=9
