On Tue, 25 Aug 1998, David C. Davies wrote:
>
> Here's the final patch for the de4x5.c driver that removes the annoying
> boot messages (with other fixes).
The pci_find_class() thing just renames it as "de4x5_find_class()", and is
still horribly ugly.
Couldn't we just use the new functionality correctly instead of emulating
an old and very ugly interface?
The new functionality really is a lot cleaner: the old code looked like
int i;
for (i = 0; i < MAXDEV; i++) {
struct pci_dev *dev = pcibios_find_class(class, index);
if (!dev)
break;
... use dev ..
}
and the new interface is just
struct pci_dev *dev = NULL;
for (;;) {
dev = pci_find_class(class, dev);
if (!dev)
break;
... use dev ...
}
which is not any more complex than the old interface to use, but it's a
lot more efficient and doesn't need any emulation.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
