On Jan 28, 2008, at 1:28 PM, J. Bruce Fields wrote:
On Mon, Jan 28, 2008 at 01:07:05PM -0500, Chuck Lever wrote:
On Jan 25, 2008, at 6:16 PM, J. Bruce Fields wrote:
The server depends on upcalls under /proc to support nfsv4 and gss.
Acked-by: NeilBrown <[EMAIL PROTECTED]>
Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
---
fs/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 487236c..e81fcd6 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1679,6 +1679,8 @@ config NFSD
select CRYPTO_MD5 if NFSD_V4
select CRYPTO if NFSD_V4
select FS_POSIX_ACL if NFSD_V4
+ select PROC_FS if NFSD_V4
+ select PROC_FS if SUNRPC_GSS
help
If you want your Linux box to act as an NFS *server*, so that
other
computers on your local network which support NFS can access
certain
I'm no Kconfig guru... but wouldn't this be better expressed as a
"depends" clause?
No idea. "Not a Kconfig guru" would be a vast understatement in my
case.
i.e. CONFIG_NFSD_V4 and SUNRPC_GSS should depend on PROC_FS --
otherwise, someone might deselect PROC_FS, then select NFSV4 or
GSS, and
get a surprise.
The drawback being that no amount of searching through the menus will
then help you figure out where the NFSv4 and GSS options have gone to,
right?
Just looking in fs/Kconfig will give you some idea. But what would
be more helpful would be a statement in the help for CONFIG_NFS that
procfs is required to support NFSv4 or GSS.
I don't care either way, but I'm inclined to leave this as is until
someone comes along with really clear and convincing criteria for when
to choose select and when to choose depends.
If NFSv4 or GSS *require* procfs to work, then "depends" is the right
choice.
As the patch stands, selecting NFSv4 will also select PROC_FS, but
you can go back and deselect PROC_FS later; and you're back in the
same boat you were in before this patch.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
-
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
