On Jan 28, 2008, at 4:48 PM, J. Bruce Fields wrote:
On Mon, Jan 28, 2008 at 04:12:26PM -0500, Chuck Lever wrote:
On Jan 28, 2008, at 1:28 PM, J. Bruce Fields wrote:
I don't care either way, but I'm inclined to leave this as is until
someone comes along with really clear and convincing criteria for
when
to choose select and when to choose depends.
If NFSv4 or GSS *require* procfs to work, then "depends" is the right
choice.
Neither CONFIG_NFS_FS nor CONFIG_NFSD_FS seem to be following this
rule?
Could you submit a patch that fixes all of those?
According to Documentation/kbuild/kconfig-language.txt, "select" is
OK to use on non-visible options like NFS_ACL_SUPPORT, LOCKD, and
SUNRPC, but generally "depends on" is preferred for setting visible
options. Apparently "select" doesn't do proper dependency checking,
it just forces the value of the named option.
NFS_FS looks correct in this regard.
However, NFSD is probably not correct... for example, instead of
"select NFSD_TCP if NFSD_V4" we should probably instead add a
"depends on NFSD_TCP" under NFSD_V4.
(Alternately, NFSD_TCP could just go away... hint hint).
I'll propose some patches to rectify some of this and fix up the out-
of-date help texts.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
-
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
