On Tue, Sep 27, 2016 at 06:08:15PM +0200, Jan Kara wrote:
> We don't check whether vma->vm_ops is NULL in do_shared_fault() so
> there's hardly any point in checking it in wp_page_shared() which gets
> called only for shared file mappings as well.
> 
> Signed-off-by: Jan Kara <j...@suse.cz>
> ---
>  mm/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index a4522e8999b2..63d9c1a54caf 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2301,7 +2301,7 @@ static int wp_page_shared(struct vm_fault *vmf, struct 
> page *old_page)
>  
>       get_page(old_page);
>  
> -     if (vma->vm_ops && vma->vm_ops->page_mkwrite) {
> +     if (vma->vm_ops->page_mkwrite) {
>               int tmp;
>  
>               pte_unmap_unlock(vmf->pte, vmf->ptl);
> -- 
> 2.6.6

Does this apply equally to the check in wp_pfn_shared()?  Both
wp_page_shared() and wp_pfn_shared() are called for shared file mappings via
do_wp_page().
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to