On Mon 17-10-16 11:40:42, Ross Zwisler wrote: > On Tue, Sep 27, 2016 at 06:08:13PM +0200, Jan Kara wrote: > > + /* Did we COW the page? */ > > + if (vmf->flags & FAULT_FLAG_WRITE && !(vmf->vma->vm_flags & VM_SHARED)) > > Oh, sorry, I did have one bit of feedback. Maybe added parens around the flag > check for readability: > > if ((vmf->flags & FAULT_FLAG_WRITE) && !(vmf->vma->vm_flags & > VM_SHARED))
Fixed. > Aside from that one nit: > > Reviewed-by: Ross Zwisler <[email protected]> Thanks! Honza -- Jan Kara <[email protected]> SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
