On 03/29/2017 04:30 PM, Dan Williams wrote: > On Wed, Mar 29, 2017 at 1:19 PM, Jeff Moyer <[email protected]> wrote: >> Dan Williams <[email protected]> writes: >> >>> On Wed, Mar 29, 2017 at 1:02 PM, Jeff Moyer <[email protected]> wrote: >>>> Dan Williams <[email protected]> writes: >>>> >>>>> +check_min_kver() >>>>> +{ >>>>> + local ver="$1" >>>>> + : "${KVER:=$(uname -r)}" >>>>> + >>>>> + [ -n "$ver" ] || return 1 >>>>> + [[ "$ver" == "$(echo -e "$ver\n$KVER" | sort -V | head -1)" ]] >>>>> +} >>>>> + >>>>> +check_min_kver "4.11" || { echo "kernel $KVER may lack latest device-dax >>>>> fixes"; exit $rc; } >>>> >>>> Can we stop with this kernel version checking, please? Test to see if >>>> you can create a device dax instance. If not, skip the test. If so, >>>> and if you have a kernel that isn't fixed, so be it, you'll get >>>> failures. >>> >>> I'd rather not. It helps me keep track of what went in where. If you >>> want to run all the tests on a random kernel just do: >>> >>> KVER="4.11.0" make check >> >> This, of course, breaks completely with distro kernels. > > Why does this break distro kernels? The KVER variable overrides "uname -r"
FYI - dax-errors.sh doesn't look at KVER. -- ljk _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
