Hi Vishal,

[auto build test WARNING on pm/linux-next]
[also build test WARNING on v4.11-rc7 next-20170420]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Vishal-Verma/acpi-nfit-fix-the-memory-error-check-in-nfit_handle_mce/20170421-084359
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git 
linux-next
config: x86_64-randconfig-x005-201716 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/acpi/nfit/mce.c: In function 'nfit_handle_mce':
>> drivers/acpi/nfit/mce.c:29:30: warning: comparison of constant '128ul' with 
>> boolean expression is always false [-Wbool-compare]
     if (!(mce->status & 0xef80) == BIT(7))
                                 ^~
>> drivers/acpi/nfit/mce.c:29:30: warning: logical not is only applied to the 
>> left hand side of comparison [-Wlogical-not-parentheses]

vim +/128ul +29 drivers/acpi/nfit/mce.c

    13   * General Public License for more details.
    14   */
    15  #include <linux/notifier.h>
    16  #include <linux/acpi.h>
    17  #include <linux/nd.h>
    18  #include <asm/mce.h>
    19  #include "nfit.h"
    20  
    21  static int nfit_handle_mce(struct notifier_block *nb, unsigned long val,
    22                          void *data)
    23  {
    24          struct mce *mce = (struct mce *)data;
    25          struct acpi_nfit_desc *acpi_desc;
    26          struct nfit_spa *nfit_spa;
    27  
    28          /* We only care about memory errors */
  > 29          if (!(mce->status & 0xef80) == BIT(7))
    30                  return NOTIFY_DONE;
    31  
    32          /*
    33           * mce->addr contains the physical addr accessed that caused the
    34           * machine check. We need to walk through the list of NFITs, 
and see
    35           * if any of them matches that address, and only then start a 
scrub.
    36           */
    37          mutex_lock(&acpi_desc_lock);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to