On Fri, 2017-05-05 at 10:14 -0700, Dave Jiang wrote: > > On 05/05/2017 10:07 AM, Kani, Toshimitsu wrote: > > On Thu, 2017-05-04 at 14:49 -0700, Dave Jiang wrote: > > > Adding list-errors command to support displaying of all badblocks > > > in relation to the device rather than the region. This allows the > > > user to know what badblocks to pass in when doing clear-error > > > calls. > > > > > > Signed-off-by: Dave Jiang <[email protected]> > > > --- > > > Documentation/ndctl-list-errors.txt | 26 +++++++ > > > builtin.h | 1 > > > ndctl/clear-error.c | 133 > > > ++++++++++++++++++++++++++++++++--- > > > ndctl/ndctl.c | 1 > > > 4 files changed, 151 insertions(+), 10 deletions(-) > > > create mode 100644 Documentation/ndctl-list-errors.txt > > > > > > diff --git a/Documentation/ndctl-list-errors.txt > > > b/Documentation/ndctl-list-errors.txt > > > new file mode 100644 > > > index 0000000..f831ba0 > > > --- /dev/null > > > +++ b/Documentation/ndctl-list-errors.txt > > > @@ -0,0 +1,26 @@ > > > +ndctl-list-errors(1) > > > +==================== > > > + > > > +NAME > > > +---- > > > +ndctl-list-errors - list badblocks specifically in relation to a > > > device > > > + > > > +SYNOPSIS > > > +-------- > > > +[verse] > > > +'ndctl list-errors' [<options>] > > > + > > > +EXAMPLES > > > +-------- > > > + > > > +List bad blocks for the provided device > > > +[verse] > > > +ndctl list-errors -f /dev/dax0.0 > > > + > > > +List all badblocks for device /dev/dax0.0. > > > > Hi Dave, > > > > I am not getting sensible values from list-errors. Also, please > > describe the output format of this command in the document. > > > > # cat /sys/bus/nd/devices/region0/size > > 17179869184 > > > > # cat /sys/class/dax/dax0.0/size > > 16909336576 > > > > # cat /sys/bus/nd/devices/region0/badblocks > > 1048576 1 > > 1572864 1 > > > > # ndctl list-errors -f /dev/dax0.0 > > 0 3145729 > > 0 3670017 > > That is very strange. It looks correct with nfit_test for me. How do > I reproduce your case or do I actually need actual hardware?
Yes, my steps need a hardware, but this badblocks handling itself should be platform-independent. I will check to see why I got these values. Thanks, -Toshi _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
