On Fri, May 5, 2017 at 12:14 PM, Dan Williams <[email protected]> wrote: > On Thu, May 4, 2017 at 2:49 PM, Dave Jiang <[email protected]> wrote: >> Adding ndctl support that will allow clearing of bad blocks for a device. >> Initial implementation will only support device dax devices. The ndctl >> takes a device path and parameters of the starting bad block, and the number >> of bad blocks to clear. >> >> Signed-off-by: Dave Jiang <[email protected]> >> --- >> Documentation/ndctl-clear-error.txt | 38 ++++++ >> builtin.h | 1 >> ndctl/Makefile.am | 1 >> ndctl/clear-error.c | 239 >> +++++++++++++++++++++++++++++++++++ >> ndctl/lib/libndctl.c | 72 +++++++++++ >> ndctl/lib/libndctl.sym | 2 >> ndctl/libndctl.h.in | 10 + >> ndctl/ndctl.c | 1 >> 8 files changed, 364 insertions(+) >> create mode 100644 Documentation/ndctl-clear-error.txt >> create mode 100644 ndctl/clear-error.c >> >> diff --git a/Documentation/ndctl-clear-error.txt >> b/Documentation/ndctl-clear-error.txt >> new file mode 100644 >> index 0000000..b14521a >> --- /dev/null >> +++ b/Documentation/ndctl-clear-error.txt >> @@ -0,0 +1,38 @@ >> +ndctl-clear-error(1) >> +==================== >> + >> +NAME >> +---- >> +ndctl-clear-error - clear badblocks for a device > > I think "clear-error" is too ambiguous of a name, lets call the > commands repair-media-errors and list-media-errors.
Actually let's kill the separate 'list-media-errors' command and just add it as optional output to our existing 'list' command. With that in place the repair command can be shortened to "repair-media" _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
