On Tue, Mar 06, 2018 at 08:59:11AM -0800, Dan Williams wrote: > >> diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c > >> index e068d72b4357..df17f1cd696d 100644 > >> --- a/drivers/nvdimm/badrange.c > >> +++ b/drivers/nvdimm/badrange.c > >> @@ -176,8 +176,7 @@ static void set_badblock(struct badblocks *bb, > >> sector_t s, int num) > >> (u64) s * 512, (u64) num * 512); > >> /* this isn't an error as the hardware will still throw an exception > >> */ > >> if (badblocks_set(bb, s, num, 1)) > >> - dev_info_once(bb->dev, "%s: failed for sector %llx\n", > >> - __func__, (u64) s); > >> + dev_info_once(bb->dev, "failed for sector %llx\n", (u64) s); > > > > I don't think you should remove this one. dev_info_once() is just a > > printk(), > > and doesn't inherit the +f flag from the dynamic debugging code. The > > __func__ > > here does add value. > > > > The rest of these look correct, though I think you missed one in each of > > nvdimm_map_release() > > This one is now fixed.
With the above fixed, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm