On Thu, 2019-07-25 at 19:55 -0700, Dan Williams wrote:
> On Wed, Jul 24, 2019 at 2:58 PM Vishal Verma <[email protected]
> > wrote:
> > The completion helpers for daxctl assumed the region arguments for
> > specifying daxctl regions were the same as ndctl regions, i.e.
> > "regionX". This is not true - daxctl region arguments are a simple
> > numeric 'id'.
> 
> Oh, that's an unfortunate difference, but too late to change now I
> think, good find.
> 
> Reviewed-by: Dan Williams <[email protected]>

Yep - though I think I like --region=0 better than --region=region0,
less redundancy.  But agreed, probably too late to change.

Thanks for reviewing these!
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to