On Wed, Oct 2, 2019 at 4:49 PM Vishal Verma <[email protected]> wrote: > > With the MEM_FIND_ZONE operation, and the expectation that it will be > called from 'daxctl list' listings, it is possible that memblock_in_dev() > gets called without sufficient privileges. If this happens, currently, > the above simply returns a 'false'. This was acceptable when the only > operations were onlining/offlining (as there would be an actual failure > later). However, it is not acceptable in the MEM_FIND_ZONE case, as it > could yeild a different answer based on the privilege level. > > Change memblock_in_dev() to return an 'int' instead of a 'bool' so that > error cases can be distinguished from actual address range test. > > Cc: Dan Williams <[email protected]> > Signed-off-by: Vishal Verma <[email protected]>
Looks good: Reviewed-by: Dan Williams <[email protected]> _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
