> -----Original Message----- > From: Dan Williams <[email protected]> > Sent: Wednesday, 1 April 2020 7:49 PM > To: Alastair D'Silva <[email protected]> > Cc: Aneesh Kumar K . V <[email protected]>; Oliver O'Halloran > <[email protected]>; Benjamin Herrenschmidt > <[email protected]>; Paul Mackerras <[email protected]>; Michael > Ellerman <[email protected]>; Frederic Barrat <[email protected]>; > Andrew Donnellan <[email protected]>; Arnd Bergmann > <[email protected]>; Greg Kroah-Hartman <[email protected]>; > Vishal Verma <[email protected]>; Dave Jiang > <[email protected]>; Ira Weiny <[email protected]>; Andrew Morton > <[email protected]>; Mauro Carvalho Chehab > <[email protected]>; David S. Miller <[email protected]>; > Rob Herring <[email protected]>; Anton Blanchard <[email protected]>; > Krzysztof Kozlowski <[email protected]>; Mahesh Salgaonkar > <[email protected]>; Madhavan Srinivasan > <[email protected]>; Cédric Le Goater <[email protected]>; Anju T > Sudhakar <[email protected]>; Hari Bathini > <[email protected]>; Thomas Gleixner <[email protected]>; Greg > Kurz <[email protected]>; Nicholas Piggin <[email protected]>; Masahiro > Yamada <[email protected]>; Alexey Kardashevskiy > <[email protected]>; Linux Kernel Mailing List <[email protected]>; > linuxppc-dev <[email protected]>; linux-nvdimm <linux- > [email protected]>; Linux MM <[email protected]> > Subject: Re: [PATCH v4 08/25] ocxl: Emit a log message showing how much > LPC memory was detected > > On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva <[email protected]> > wrote: > > > > This patch emits a message showing how much LPC memory & special > > purpose memory was detected on an OCXL device. > > > > Signed-off-by: Alastair D'Silva <[email protected]> > > Acked-by: Frederic Barrat <[email protected]> > > Acked-by: Andrew Donnellan <[email protected]> > > --- > > drivers/misc/ocxl/config.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > > index a62e3d7db2bf..69cca341d446 100644 > > --- a/drivers/misc/ocxl/config.c > > +++ b/drivers/misc/ocxl/config.c > > @@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(struct > pci_dev *dev, > > afu->special_purpose_mem_size = > > total_mem_size - lpc_mem_size; > > } > > + > > + dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and special > purpose memory of %#llx bytes\n", > > + afu->lpc_mem_size, afu->special_purpose_mem_size); > > A patch for a single log message is too fine grained for my taste, let's > squash > this into another patch in the series. >
I'm not sure there's a great place for it. At a pinch, it could with the previous patch, but they are really different layers. > > + > > return 0; > > } > > > > -- > > 2.24.1 > > > > > -- > This email has been checked for viruses by AVG. > https://www.avg.com _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
