Hello!

On 18.04.2020 21:41, Randy Dunlap wrote:

Fix gcc empty-body warning when -Wextra is used:

../fs/nfsd/nfs4state.c:3898:3: warning: suggest braces around empty body in an 
‘else’ statement [-Wempty-body]

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Chuck Lever <[email protected]>
Cc: [email protected]
---
  fs/nfsd/nfs4state.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20200417.orig/fs/nfsd/nfs4state.c
+++ linux-next-20200417/fs/nfsd/nfs4state.c
[...]
@@ -3895,7 +3896,7 @@ nfsd4_setclientid(struct svc_rqst *rqstp
                copy_clid(new, conf);
                gen_confirm(new, nn);
        } else /* case 4 (new client) or cases 2, 3 (client reboot): */
-               ;
+               do_empty();

In this case explicit {} would probably have been better, as described in Documentation/process/coding-style.rst, clause (3).

MBR, Sergei
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to