* Russell King - ARM Linux <[EMAIL PROTECTED]> [080819 20:30]: > On Fri, Jun 06, 2008 at 07:12:33PM -0700, Tony Lindgren wrote: > > From: Paul Walmsley <[EMAIL PROTECTED]> > > > > Add clkdm_get_pwrdm() to the clockdomain code. It will return a > > pointer to the powerdomain struct that the clockdomain is contained > > within. Used by the PM code. > > > > Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> > > Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> > > This patch should have been merged into the patch creating clockdomain.c > before it was sent upstream. It's clearly a function which was missed > out of Paul's original patch. > > There's no requirement to ensure that every bit of microscopic history > behind the development of a feature is preserved into the mainline > kernel tree - it's actually preferred that it isn't. > > Another reason for doing so is to cut down on the amount of reviewing > that has to be done upstream. Given the amount of churn in OMAP land, > reducing compressing changes _sanely_ should be a priority.
Yeah I agree. > > diff --git a/include/asm-arm/arch-omap/clockdomain.h > > b/include/asm-arm/arch-omap/clockdomain.h > > index d2a4551..e71fee4 100644 > > --- a/include/asm-arm/arch-omap/clockdomain.h > > +++ b/include/asm-arm/arch-omap/clockdomain.h > > @@ -94,6 +94,9 @@ struct clockdomain *clkdm_lookup(const char *name); > > int clkdm_for_each(int (*fn)(struct clockdomain *clkdm)); > > struct powerdomain *clkdm_get_pwrdm(struct clockdomain *clkdm); > > > > +int clkdm_for_each(int (*fn)(struct clockdomain *clkdm)); > > +struct powerdomain *clkdm_get_pwrdm(struct clockdomain *clkdm); > > + > > These prototypes are already there, so this isn't required. Will fix. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
