On Monday 01 September 2008, stanley.miao wrote:
> +       if(!is_sil_rev_less_than(OMAP3430_REV_ES2_0)) {

But checkpatch.pl rejected that, yes?  Fixed in a later
version I see.

... and in "static int sdp2430_panel_enable(...)" this would
seem to be wrong.  But for that matter, lcd_2430sdp.c should
not be relevant for any 3430 board anyway...

If that file is, oddly, being shared between two boards ...
then put that code in the "if (machine_is_omap_3430sdp())"
block.  And someone should consider renaming the file if
it's not specific to the 2430 SDP.



--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to