* Russell King - ARM Linux <[EMAIL PROTECTED]> [081009 18:07]:
> On Fri, Oct 03, 2008 at 03:09:35PM +0300, Tony Lindgren wrote:
> > @@ -51,12 +53,39 @@ static struct map_desc omap2_io_desc[] __initdata = {
> >             .type           = MT_DEVICE
> >     },
> >     {
> > -           .virtual        = L4_24XX_VIRT,
> > -           .pfn            = __phys_to_pfn(L4_24XX_PHYS),
> > -           .length         = L4_24XX_SIZE,
> > -           .type           = MT_DEVICE
> > +           .virtual        = L4_24XX_VIRT,
> > +           .pfn            = __phys_to_pfn(L4_24XX_PHYS),
> > +           .length         = L4_24XX_SIZE,
> > +           .type           = MT_DEVICE
> 
> It would be good to transition all of the OMAP structure initializations
> over to using a trailing ',' on the last initializer as per the rest of
> the kernel source.  Having that additional ',' makes script based
> rewriting of the contents of structures a lot easier, and reduces the
> chances of patches clashing.
> 
> I'm not suggesting it as something that needs to be done now though.

Sure, I'll send you a patch for that after the merge window. Along
with the fix for omap cpu detection and mmc init.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to