On Tuesday 13 January 2009, Koen Kooi wrote:
> ------------[ cut here ]------------
> WARNING: at arch/arm/mach-omap2/clock.c:1094 omap2_clk_register
> +0x24/0x3c()
> Modules linked in:
> [<c003b824>] (dump_stack+0x0/0x14) from [<c005b180>] (warn_on_slowpath
> +0x4c/0x68)
Just in the cause of better diagnostics ... that looks like maybe
if (!clk->clkdm.name) {
pr_debug("clock: %s: missing clockdomain", clk->name);
WARN_ON(1);
return -EINVAL;
}
triggered. A better way to write that, in recent kernels, is
if (WARN(!clk->clkdm.name,
"clock: %s missing clockdomain\n", clk->name))
return -EINVAL;
Where "better" includes "diagnostic message is always present"
and thus "line numbers matter less". (Line 1094 in my kernel
is the right bracket above, not the WARN_ON...)
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
