On Sun, Feb 22, 2009 at 7:21 AM, Hiroshi DOYU <[email protected]> wrote: > Hi Felipe, > > From: ext Felipe Contreras <[email protected]> > Subject: [PATCH] dspbridge: wait less and check the mailbox more > Date: Sat, 21 Feb 2009 00:04:17 +0100 > >> From: Felipe Contreras <[email protected]> >> >> Profiling showed the __delay function is called a lot; checking the mbox >> more often seems to decrease the usage by 2/3 according to OProfile. > > Good finding. > >> The changes are based on 'arch/arm/plat-omap/mailbox.c'. Tested on OMAP3430. >> >> Also, remove HW_MBOX_IsFull since it's not used by anybody. > > Woundn't it be better to split this one into some logical parts, > tunning up part(decreasing delay) and cleanup part(the others)?
I can do that, but my objective is to decrease CPU usage... increasing the frequency of mbox checking means more calls to HW_MBOX_IsFull. So the 'cleanup' part must be applied too for performance reasons. > Home brewed MACROs themselves like UTIL_Wait() are basically evil from > kernel source readibility perspective, but keeping consistency within > specific module may be more important and this kind of cleaning up > would be better to be done at onece over a module, in separate > patches. I can do that too. Note that the author is wrong: contrers -> contreras -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
