On Tue, Feb 24, 2009 at 12:06 AM, Kanigeri, Hari <[email protected]> wrote: > Hi Felipe, > >> HW_MBOX_IsFull has many convoluted macros and is used only once. Clean >> it up so it's easier to see what it's actually doing. > > -- Is this the reason you added a new function that checks if fifo is full or > is there any issue with the existing function ?
fifo_full should do exactly the same as HW_MBOX_IsFulll, I just removed all the macros and used __raw_readl instead. I could have removed the fifo_full function and do the __raw_readl directly, but I thought this way it was more readable. The main reason I cleaned the function was for performance reasons; remove unnecessary checks, extra steps, and the function call (now inline). -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
