* Roger Quadros <[email protected]> [140825 03:39]: > Hi Tony, > > On 08/23/2014 02:01 AM, Tony Lindgren wrote: > > * Pekon Gupta <[email protected]> [140723 11:20]: > >> Each GPMC chip-select needs to be configured for (base-address,CS-size) so > >> that > >> GPMC understands the address-space allocated to device connected > >> externally. > >> These chip-select configurations (base-address, CS-size) follow some basic > >> mapping rules like: > >> - The CS size is programmable from 256 MBytes to 16 MBytes (must be a > >> power of 2) > >> and is defined by the mask field. Attached memory smaller than the > >> programmed > >> CS region size is accessed through the entire CS region (aliasing). > >> - The programmed 'base-address' must be aligned to the 'CS-size' boundary > >> and > >> be a power of 2. > >> - Valid CS-size values are {256MB(max), 128MB, 64MB, 32MB and 16MB (min)} > >> Any intermediate values creates holes in the chip-select memory-map. > >> > >> This patch adds above checks in gpmc_cs_remap() so that any invalid value > >> passed by DT <reg> property can be filtered before actually allocating the > >> address space. > >> > >> Signed-off-by: Pekon Gupta <[email protected]> > > > > Looks like size typos Roger mentioned are fixed in this one, so > > applying into omap-for-v3.17/fixes thanks. > > I don't see the typos fixed here. I'll reply with a v2 patch.
Oops indeed. I'll redo the fixes branch to avoid extra churn and apply your updated version into omap-for-v3.17/fixes-v2. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
