Hi Hari, From: "ext Kanigeri, Hari" <[email protected]> Subject: RE: [PATCH 1/1] DSPBRIDGE: move platform_device_register under mach-omap2 Date: Fri, 27 Mar 2009 14:42:18 +0100
> Hi Doyu-San, > > > > I am still going through the patch, but one quick question regarding > > > this. One of the requirements of DSP memory pool is that it should > > > be physically contiguous and non-cacheable. I hope the below patch > > > is taking care of this requirement. > > > > This patch reserves a *contigious* physical memory area and passes > > this physical address to the bridge driver through > > ldm(platform_data). Then this area is ioremap()'ed in > > "MEM_ExtPhysPoolInit()". So it should be non-cachable and contigious. > > -- We validated your patch with TI's internal test suite and it looks good. Thank you for your effort. > The only comment I have is with this patch now we would require 2 > modules to insert for DSP Bridge to work. I think it would be nice > if we compile these 2 modules into 1 module so that we have only > DSPBridge module. Hm..then, how about the following? diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 1ed6621..d427c90 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -35,7 +35,9 @@ obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o obj-$(CONFIG_OMAP_PM_SRF) += resource34xx.o -obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o + +dspbridge-$(CONFIG_MPU_BRIDGE) := dspbridge.o +obj-y += $(dspbridge-m) $(drpbridge-y) # DSP obj-$(CONFIG_OMAP_MMU_FWK) += mmu_mach.o -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
